Messages in this thread | | | Date | Tue, 3 May 2011 08:48:13 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/4] perf: Add persistent event facilities |
| |
* Ingo Molnar <mingo@elte.hu> wrote:
> > include/linux/perf_event.h | 22 +++++++++++++++- > > kernel/events/Makefile | 2 +- > > kernel/events/core.c | 29 ++++++++++++++++++--- > > kernel/events/persistent.c | 59 ++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 105 insertions(+), 7 deletions(-) > > create mode 100644 kernel/events/persistent.c > > I really like this new kernel/events/ subdirectory you created - we could move > the other perf_events.c facilities there as well, and maybe split up the file a > bit, it's 7.5 KLOC now which is a bit excessive. > > We should probably do that before adding kernel/events/persistent.c - wanna do > those changes? Initial commit should be a mostly-rename thing: > kernel/perf_events.c could move into kernel/events/core.c or so - and then we > could split the core up some more, into various facilities.
Looks like you have a time machine and after reading my feedback you have have sneaked this exact change into patch 1/4! :-)
( The alternative interpretation is that i should start reading series at the beginning - not in the most interesting looking (largest) places where i would stupidly ask for changes you've put into 1/4 already. )
Thanks,
Ingo
| |