Messages in this thread | | | Subject | Re: [RFC][PATCH] PM: Print a warning if firmware is requested when tasks are frozen | From | Valdis.Kletnieks@vt ... | Date | Tue, 03 May 2011 11:47:23 -0400 |
| |
On Tue, 03 May 2011 13:02:08 +0200, "Rafael J. Wysocki" said:
> Although the WARN_ON output will probably not make it to the user's screen > immediately, the resume will continue without the delay, because error code > will be returned as soon as the WARN_ON triggers. > > The user will likely notice the device not working after the resume and will > look at dmesg output. :-)
Good point. I obviously didn't have enough caffeine to think it through. ;)
> > 2) What percent of the time the WARN_ON output will itself make the user > > think the resume has died rather than just being slow, causing them to power > > cycle and hope for a clean boot? > > > > Maybe something like this instead? > > > > if (WARN_ON(usermodehelper_is_disable()))) { > > printk(KERN_WARNING "Resume continuing, but firmware for %s not loaded", device); > > It's useful, but I'd rather do > > dev_info(device, "firmware: %s will not be loaded\n", name);
That works too. :)
> OK, updated patch is appended.
Looks good to me.
[unhandled content-type:application/pgp-signature] | |