Messages in this thread | | | Date | Tue, 3 May 2011 10:06:47 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [RFC patch 29/32] trace event asoc remove semicolons |
| |
* Mark Brown (broonie@opensource.wolfsonmicro.com) wrote: > On Mon, May 02, 2011 at 05:11:52PM -0400, Mathieu Desnoyers wrote: > > Part of the gradual TRACE_EVENT() semicolon removal. Enables creation of array > > of events, thus saving space for trace event probes. > > Can I apply this in my tree or does this depend on some earlier patch I > don't have?
Hi Mark,
This depends on a preliminary ftrace cleanup patch I just forwarded to you. LKML has eaten that patch due to too many CC. [ insert favorite expression of frustration here ]. But I think the best way to proceed would be to get a Acked-by from you and let Steven pull the patch through the tracing tree.
> > > +#ifndef _TRACE_ASOC_DEF_ > > +#define _TRACE_ASOC_DEF_ > > + > > struct snd_soc_jack; > > struct snd_soc_codec; > > struct snd_soc_card; > > struct snd_soc_dapm_widget; > > > > +#endif /* _TRACE_ASOC_DEF_ */ > > This is an unrelated change and should be split out. Frankly I'm not > that this is an improvement anyway, the struct declarations aren't going > to do any harm...
Yes, this change is related, because these declarations will cause harm. The structure declaration cannot be put within an array declaration, because then they won't be simply "ignored": they will try to declare structures within an array, which is not valid. This is why I did this change in the same patch.
Thanks,
Mathieu
-- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com
| |