lkml.org 
[lkml]   [2011]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed
On May 30 August Lilleaas wrote:
> On Sun, May 29, 2011 at 11:44 PM, Stefan Richter
> <stefanr@s5r6.in-berlin.de>wrote:
>
> > Who deprecated it and why?
> >
>
> To be frank, the motivation for this patch was a message from script/
> checkpatch.pl when scouring random files for warnings. (This is my first
> contribution to the kernel.)
>
> Just did some much needed investigation though. It was deprecated for
> portability, specifically to avoid GCC specific code. See commit
> 82ddcb040570411fc2d421d96b3e69711c670328.

OK, thanks for the info.

> > Shouldn't you add "#include <linux/compiler.h>" now?
> >
>
> You're right. I'll read up on updating patches and get at it.

I will just add it when I commit the patch.

(One way to update a patch is to make it the top commit, then edit files
and "git add ..." them as necessary, then "git commit --amend". There are
other ways of course.)
--
Stefan Richter
-=====-==-== -=-= ====-
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2011-05-30 01:19    [W:0.067 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site