lkml.org 
[lkml]   [2011]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] x86-64: Replace vsyscall gettimeofday fallback with int 0xcc
On Fri, 27 May 2011, Andy Lutomirski wrote:

> Now the only way to issue a syscall with side effects through the
> vsyscall page is to call a misaligned instruction. I haven't
> checked for that.
>
> Signed-off-by: Andy Lutomirski <luto@mit.edu>
> ---
> arch/x86/include/asm/traps.h | 4 +++
> arch/x86/include/asm/vsyscall.h | 6 +++++
> arch/x86/kernel/entry_64.S | 2 +
> arch/x86/kernel/traps.c | 4 +++
> arch/x86/kernel/vsyscall_64.c | 47 ++++++++++++++++++++++++++++++++++-----
> 5 files changed, 57 insertions(+), 6 deletions(-)
>

one very tiny nit below.

[...]
> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> index b9b6716..d34894e 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -872,6 +872,10 @@ void __init trap_init(void)
> set_bit(SYSCALL_VECTOR, used_vectors);
> #endif
>
> + set_system_intr_gate(0xCC, &intcc);
> + set_bit(0xCC, used_vectors);
> + printk(KERN_ERR "intcc gate isntalled\n");

Let's spell the error message correctly:

printk(KERN_ERR "intcc gate installed\n");

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2011-05-29 22:01    [W:0.325 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site