lkml.org 
[lkml]   [2011]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd
Date
Hi Alan,

> This patch (as1468) changes the Kconfig definition for
> USB_GADGET_DUALSPEED. This option is determined entirely by which
> device controller drivers are to be built, through Select statements;
> it does not need to be (and should not be) configurable by the user.
>
> Also, the "default n" line is superfluous -- everything defaults to N.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
>
> ---
>
> drivers/usb/gadget/Kconfig | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Index: usb-2.6/drivers/usb/gadget/Kconfig
> ===================================================================
> --- usb-2.6.orig/drivers/usb/gadget/Kconfig
> +++ usb-2.6/drivers/usb/gadget/Kconfig
> @@ -597,13 +597,10 @@ config USB_DUMMY_HCD
>
> endchoice
>
> +# Selected by UDC drivers that support high-speed operation.
> config USB_GADGET_DUALSPEED
> bool
> depends on USB_GADGET
> - default n
> - help
> - Means that gadget drivers should include extra descriptors
> - and code to handle dual-speed controllers.
>
> #
> # USB Gadget Drivers
>

I was making the same change for SS and I think that if you're about to send
this patch to Greg, it might need a small addition:
At the moment dummy_hcd supports high_speed so I think if this option is no
longer configurable by user you should set this flag when dummy_hcd is
selected:

config USB_DUMMY_HCD
tristate
depends on USB_GADGET_DUMMY_HCD
default USB_GADGET
select USB_GADGET_SELECTED
select USB_GADGET_DUALSPEED


Best regards,
Tanya Brokhman
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum










\
 
 \ /
  Last update: 2011-05-28 13:07    [from the cache]
©2003-2011 Jasper Spaans