Messages in this thread | | | Date | Sat, 28 May 2011 20:04:34 +0200 | From | Ingo Molnar <> | Subject | Re: Kernel crash after using new Intel NIC (igb) |
| |
* Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > +static inline int atomic_add_unless(atomic_t *v, int a, int u) > > +{ > > + return __atomic_add_unless(v, a, u) != u; > > } > > > > #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0) > > As I said, atomic_add_unless() has several implementations in > various arches. You must take care of all, not only x86.
It's a bit sad to see local hacks to generic facilities committed upstream like that.
Arun: the x86 bits look good at first sight.
Thanks,
Ingo
| |