Messages in this thread | | | From | Heiko Stübner <> | Subject | Re: [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc | Date | Sat, 28 May 2011 19:48:12 +0200 |
| |
Am Samstag 28 Mai 2011, 19:36:32 schrieb Joe Perches: > diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c > index 3ec4923..86573e2 100644 > --- a/drivers/video/arcfb.c > +++ b/drivers/video/arcfb.c > @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct > platform_device *dev) > > /* We need a flat backing store for the Arc's > less-flat actual paged framebuffer */ > - if (!(videomemory = vmalloc(videomemorysize))) > + videomemory = vmalloc(videomemorysize); > + if (!videomemory) > return retval; shouldn't this be vzalloc too?
> - memset(videomemory, 0, videomemorysize); > - > info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev); > if (!info) > goto err;
Heiko
| |