[lkml]   [2011]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH v3 7/10] workqueue: add WQ_IDLEPRI
    Hello, KAMEZAWA.

    On Thu, May 26, 2011 at 02:30:24PM +0900, KAMEZAWA Hiroyuki wrote:
    > When this idea came to me, I wonder which is better to maintain
    > memcg's thread pool or add support in workqueue for generic use. In
    > genral, I feel enhancing genric one is, wrote this one.

    Sure, if it's something which can be useful for other users, it makes
    sense to make it generic.

    > Index: memcg_async/include/linux/workqueue.h
    > ===================================================================
    > --- memcg_async.orig/include/linux/workqueue.h
    > +++ memcg_async/include/linux/workqueue.h
    > @@ -56,7 +56,8 @@ enum {
    > /* special cpu IDs */
    > - WORK_CPU_NONE = NR_CPUS + 1,
    > + WORK_CPU_NONE = NR_CPUS + 2,

    Hmmm... so, you're defining another fake CPU a la unbound CPU. I'm
    not sure whether it's really necessary to create its own worker pool
    tho. The reason why SCHED_OTHER is necessary is because it may
    consume large amount of CPU cycles. Workqueue already has UNBOUND -
    for an unbound one, workqueue code simply acts as generic worker pool
    provider and everything other than work item dispatching and worker
    management are deferred to scheduler and the workqueue user.

    Is there any reason memcg can't just use UNBOUND workqueue and set
    scheduling priority when the work item starts and restore it when it's
    done? If it's gonna be using UNBOUND at all, I don't think changing
    scheduling policy would be a noticeable overhead and I find having
    separate worker pools depending on scheduling priority somewhat silly.

    We can add a mechanism to manage work item scheduler priority to
    workqueue if necessary tho, I think. But that would be per-workqueue
    attribute which is applied during execution, not something per-gcwq.



     \ /
      Last update: 2011-05-26 11:41    [W:0.030 / U:3.908 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site