Messages in this thread | | | Date | Wed, 25 May 2011 08:59:18 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/3] x86, intel: Use cpu_update for Atom errata check |
| |
* Andi Kleen <andi@firstfloor.org> wrote:
> From: Andi Kleen <ak@linux.intel.com> > > Now that the cpu update level is available the Atom PSE errata > check can use it directly without reading the MSR again. > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > arch/x86/kernel/cpu/intel.c | 15 ++++-----------
Ok, it's nice that you have split this one out.
Please also split out the MCE printk change you did in the first patch - even if it's a oneliner we want the first patch to only include changes focused to the primary purpose alone: the introduction of x86_cpu::microcode_version.
Also, please split the first patch into two other parts: a first one that factors out the Intel microcode-version MSR function into a separate function, and the second patch that introduces the x86_cpu::microcode_version field and fills it in in the CPU detection code and keeps it updated in the microcode driver.
Thanks,
Ingo
| |