Messages in this thread | | | Date | Wed, 25 May 2011 12:39:09 -0700 | From | Arun Sharma <> | Subject | Re: [PATCH 6/6] kbuild: cleanup the rpm buildroot |
| |
On Wed, May 25, 2011 at 03:54:58PM +0200, Michal Marek wrote: > On Tue, May 17, 2011 at 10:36:19AM -0700, Arun Sharma wrote: > > echo "%build" > > +echo 'rm -rf $RPM_BUILD_ROOT' > > Don't do it, this allows another user to create their or $RPM_BUILD_ROOT > and let you package it.
Here's the motivation for the change:
mkspec has a BuildRoot that is deterministic (i.e. the next time I rebuild I get the same buildroot)
> echo "BuildRoot: %{_tmppath}/%{name}-%{PACKAGE_VERSION}-root"
So if I were to restart a broken build, the build root could have old files that break the build even after the breakage is fixed.
-Arun
| |