Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 25 May 2011 11:55:57 -0700 | Subject | Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS] |
| |
On Wed, May 25, 2011 at 11:44 AM, Parag Warudkar <parag.lkml@gmail.com> wrote: > > Below patch pushes the check down to ioctl functions and hopefully should > cover more ioctl-on-gone-device cases by returning -ENXIO if an attempt > was made to submit request to a non-running device.
Can we please not duplicate complicated logic like that?
IOW, just make a helper function for it.
That said, isn't this all *exactly* what scsi_prep_state_check() is supposed to check for? Why isn't that called, or if called, why isn't it doing the right thing?
Linus
| |