Messages in this thread | | | Date | Wed, 25 May 2011 17:20:08 +0200 | Subject | Re: [PATCH 1/4] include/linux/printk.h is not self-contained | From | Geert Uytterhoeven <> |
| |
On Wed, May 25, 2011 at 16:42, Joe Perches <joe@perches.com> wrote: > On Wed, 2011-05-25 at 11:09 +0200, y@mail.of.borg wrote:
Sorry, that email address is a relic from typing one too many "y" responses to git-send-email questions.
>> From: Geert Uytterhoeven <geert@linux-m68k.org> >> <linux/printk.h> needs to include >> - <stdarg.h> for "va_list", >> - <linux/linkage.h> for "asmlinkage", >> - <linux/types.h> for "bool". > > I wonder if printk should be self-contained. > > If so, this patch should also add: > > #include <linux/dynamic_debug.h> > #include <linux/ratelimit.h>
Hmm, it does compile without those, as long as you don't use dynamic debug or ratelimit.
> If not, maybe add: > > #ifndef _LINUX_KERNEL_H > #error don't include <linux/printk.h> directly, use <linux/kernel.h> > #endif
That's another possibility. We already have several users, though.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |