lkml.org 
[lkml]   [2011]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: pch_gpio: Support new device ML7223
    Date
    Hello Tomoya,

    On Monday 09 May 2011 12:58:49 Tomoya wrote:
    > diff --git a/drivers/gpio/pch_gpio.c b/drivers/gpio/pch_gpio.c
    > index f970a5f..36919e7 100644
    > --- a/drivers/gpio/pch_gpio.c
    > +++ b/drivers/gpio/pch_gpio.c
    > @@ -283,8 +283,10 @@ static int pch_gpio_resume(struct pci_dev *pdev)
    > #define pch_gpio_resume NULL
    > #endif
    >
    > +#define PCI_VENDOR_ID_ROHM 0x10DB

    Should this be moved to pci_ids.h?

    > static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = {
    > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
    > + { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },

    Likewise for the product ID. While at it, the ID for EG20T could also be moved
    in a separate patch.

    > { 0, }
    > };
    > MODULE_DEVICE_TABLE(pci, pch_gpio_pcidev_id);

    Regards,
    Alexander


    \
     
     \ /
      Last update: 2011-05-25 14:11    [W:0.020 / U:121.096 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site