lkml.org 
[lkml]   [2011]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Cleanup pc87413 watchdog driver to use request_muxed_region for SuperIO area
Hi Jonathan,

> > I don't think this is the correct way to do this. You do the
> > request_muxed_region only at init and exit of the module.
>
> I do a single request_muxed_region in the init function, and release it
> at the end of the init function. It's only necessary to hold the LPC
> region while the WDT functionality is enabled and the base address for
> the SWC block is retrieved.
>
> After that point all access is via the SWC region, so there's no need to
> call request_muxed_region. The call in the exit function releases the
> SWC block. We're not holding the LPC region for the entire duration of
> the driver being loaded.

Added to linux-2.6-watchdog-next.

Kind regards,
Wim.



\
 
 \ /
  Last update: 2011-05-24 09:19    [W:2.107 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site