Messages in this thread | | | Date | Tue, 24 May 2011 17:47:16 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 1/3] x86, intel: Output microcode revision |
| |
On Tue, May 24, 2011 at 05:25:08PM -0700, Yu, Fenghua wrote: > >@@ -300,6 +295,7 @@ static int apply_microcode(int cpu) > > struct ucode_cpu_info *uci; > > unsigned int val[2]; > > int cpu_num; > >+ struct cpuinfo_x86 *c = &cpu_data(cpu_num); > > This is wrong. cpu_num is not initialized yet at this point. You need to assign c after cpu_num is initialized in the next statement.
Thanks. Stupid bug. I'll post an updated version.
-Andi
| |