Messages in this thread | | | Date | Tue, 24 May 2011 13:28:25 -0400 (EDT) | Subject | Re: [PATCH v4 1/1] igmp: call ip_mc_clear_src() only when we have no users of ip_mc_list | From | David Miller <> |
| |
From: Veaceslav Falico <vfalico@redhat.com> Date: Tue, 24 May 2011 11:15:05 +0200
> In igmp_group_dropped() we call ip_mc_clear_src(), which resets the number > of source filters per mulitcast. However, igmp_group_dropped() is also > called on NETDEV_DOWN, NETDEV_PRE_TYPE_CHANGE and NETDEV_UNREGISTER, which > means that the group might get added back on NETDEV_UP, NETDEV_REGISTER and > NETDEV_POST_TYPE_CHANGE respectively, leaving us with broken source > filters. > > To fix that, we must clear the source filters only when there are no users > in the ip_mc_list, i.e. in ip_mc_dec_group() and on device destroy. > > Acked-by: David L Stevens <dlstevens@us.ibm.com> > Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Applied.
| |