Messages in this thread |  | | | Date | Tue, 24 May 2011 18:49:35 +0200 | | From | Sam Ravnborg <> | | Subject | Re: [PATCH] Kconfig: add warning about permission of config file |
| |
> >>> > >>> Arnaud's point is that your patch should not be necessary at all, > >>> because kconfig already checks the return value of the fopen() call in > >>> conf_write() and prints the above message if it fails. So do you have a > >>> testcase where make<...>config without your patch returns without > >>> error, but the configuration is not written? > >> > >> Sorry for misunderstanding. > >> Indeed, make *config which use 'conf' (e.g. oldconfig, defconfig...) > >> raise error. > >> And only xconfig and gconfig don't write the configuration without > >> error. > > > > I see, qconf lacks a check for the return value of conf_write() in > > ConfigMainWindow::closeEvent(), gconf does check the return value, but only > > displays it in the bottom box of the main window instead of a message box. > > Neither of them return failure in the error case. These bugs should be > > indeed fixed. > > > agree. The only thing that a write-access check up-front could be useful for would be to launch a front-end in ReadOnly mode. And this is not supported by any of them today IIRC.
Sam
|  |