lkml.org 
[lkml]   [2011]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -next] x86: apic_flat_64.c needs module.h
    On 05/23/2011 09:43 PM, Randy Dunlap wrote:
    > From: Randy Dunlap <randy.dunlap@oracle.com>
    >
    > apic_flat_64.c needs to include module.h to fix these warnings:
    >
    > arch/x86/kernel/apic/apic_flat_64.c:31: warning: data definition has no type or storage class
    > arch/x86/kernel/apic/apic_flat_64.c:31: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
    > arch/x86/kernel/apic/apic_flat_64.c:31: warning: parameter names (without types) in function declaration
    >
    > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    > ---
    > arch/x86/kernel/apic/apic_flat_64.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > --- linux-next-20110523.orig/arch/x86/kernel/apic/apic_flat_64.c
    > +++ linux-next-20110523/arch/x86/kernel/apic/apic_flat_64.c
    > @@ -16,6 +16,7 @@
    > #include <linux/ctype.h>
    > #include <linux/init.h>
    > #include <linux/hardirq.h>
    > +#include <linux/module.h>
    > #include <asm/smp.h>
    > #include <asm/apic.h>
    > #include <asm/ipi.h>

    Thanks Randy! For some reason I didn't hit this problem while
    were compiling the kernel and testing it (I usually do not use
    modules though).

    I've CC'ed Ingo and Suresh.

    --
    Cyrill


    \
     
     \ /
      Last update: 2011-05-23 19:53    [W:4.197 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site