Messages in this thread | | | Date | Mon, 23 May 2011 11:37:04 +0200 | From | Kristoffer Glembo <> | Subject | Re: [PATCH 2/2] drivers/amba: probe via device tree |
| |
Hi,
Grant Likely wrote: > In the case we're talking about the bus really is an AMBA bus, and all > the devices on it are in some sense real amba devices. The problem is > that not all of the devices on the bus implement peripheral ID > registers or other mechanisms that good upstanding AMBA devices are > expected to have.
Before we go hardware bashing of non primecell AMBA devices I would just want to point out that the primecell stuff is not part of the AMBA specification.
So the "amba bus" should really have a way of marking which devices are primecell devices instead of assuming this.
We (Aeroflex Gaisler) use an AMBA bus on our LEON SPARC chips but don't have any primecells devices. We went the of_platform_driver route after concluding that the AMBA bus in Linux is really not an AMBA bus at all. Our bus is fully probable though as all information about the present devices are memory mapped in a "plug and play" area.
On the other hand, there is not much point of an AMBA bus driver which does nothing more than the platform driver. But AMBA is really a misnomer in this case.
/Kristoffer
| |