Messages in this thread | | | Subject | Re: [PATCH] regulator: Fix off-by-one value range checking for mc13xxx_regulator_get_voltage | From | Liam Girdwood <> | Date | Sat, 21 May 2011 12:54:02 +0100 |
| |
On Wed, 2011-05-18 at 20:56 +0800, Axel Lin wrote: > We use val as array index, > thus the valid value rangae for val should be 0 .. n_voltages-1. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > drivers/regulator/mc13xxx-regulator-core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c > index 2bb5de1..bc27ab1 100644 > --- a/drivers/regulator/mc13xxx-regulator-core.c > +++ b/drivers/regulator/mc13xxx-regulator-core.c > @@ -174,7 +174,7 @@ static int mc13xxx_regulator_get_voltage(struct regulator_dev *rdev) > > dev_dbg(rdev_get_dev(rdev), "%s id: %d val: %d\n", __func__, id, val); > > - BUG_ON(val > mc13xxx_regulators[id].desc.n_voltages); > + BUG_ON(val >= mc13xxx_regulators[id].desc.n_voltages); > > return mc13xxx_regulators[id].voltages[val]; > }
Applied
Thanks
Liam
| |