Messages in this thread | | | Subject | Re: PATCH] patch to generate warning when signed-of line in patch in not proper | From | Joe Perches <> | Date | Sat, 21 May 2011 12:52:44 -0700 |
| |
On Sun, 2011-05-22 at 01:08 +0530, anish wrote: > On Sat, May 21, 2011 at 9:33 PM, Joe Perches <joe@perches.com> wrote: > >>If you do this, why not do it for all signature types? > >>our $Valid_Signatures "(?:Signed-off-by:|Reviewed-by:|Acked-by:)" > Definitely.Please check below modified patch. [] > This patch generates warning when there is no space betweenthe patch > submitter name and successive mail-id.As suggested by > Joe Perches(joe@perches.com) that we can do this for > all signature types.
Typos and spacing issues in commit message.
> Signed-off-by: anish kumar <anish198519851985@gmail.com> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > +my $sign; > +my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:"); [] > +#check the patch for a signoff/Reviewed/Acked/Tested: > + foreach $sign (@signs) {
It's inefficient to loop for this. I think what I suggested is neater, but what you're doing is OK.
Your email subject line should be more like:
[PATCH] checkpatch: More signature format verification
And when you revise patches, use some version number in the [PATCH] block like:
[PATCH v2] checkpatch: etc...
cheers, Joe
| |