Messages in this thread Patch in this message | | | Subject | Re: PATCH] patch to generate warning when signed-of line in patch in not proper | From | Joe Perches <> | Date | Sat, 21 May 2011 09:03:06 -0700 |
| |
On Sat, 2011-05-21 at 20:14 +0530, anish singh wrote: > Re-sending to get some comments on this. > > On Thu, May 19, 2011 at 10:53 PM, anish <anish198519851985@gmail.com> > wrote: > From: anish kumar <anish198519851985@gmail.com> > > This patch generates warning when there is no space between > the > patch submitter name and successive mail-id.
If you do this, why not do it for all signature types?
our $Valid_Signatures "(?:Signed-off-by:|Reviewed-by:|Acked-by:)"
> Signed-off-by: anish kumar <anish198519851985@gmail.com> > --- > scripts/checkpatch.pl | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index d867081..437c6d4 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1373,10 +1373,16 @@ sub process { > WARN("Signed-off-by: is the > preferred form\n" . > $herecurr); > } > - if ($line =~ /^\s*signed-off-by:\S/i) > { > - WARN("space required after > Signed-off-by:\n" .
if ($line =~ /^(\s*)($ValidSignatures)(\s*)(.*)$/i) { my $space_before = $1; my $sign_off = $2; my $space_after = $3; my $email = $4; if (defined $space_before && $space_before ne "") { warning (no space before...) } if ($sign_off !~ /$Valid_Signature/) { warning (signature case...) } if (!defined $space_after || $space_after ne " ") { warning (need only one space after colon...) } if (!validate_email($4)) { warning (bad email...)
| |