Messages in this thread | | | Date | Thu, 19 May 2011 23:54:49 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] kstrtox: drop kstrtol()/kstrtoul() when possible |
| |
On Fri, 20 May 2011 09:48:27 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Fri, May 20, 2011 at 08:20:42AM +0200, Geert Uytterhoeven wrote: > > On Fri, May 20, 2011 at 08:15, Alexey Dobriyan <adobriyan@gmail.com> wrote: > > > If "long" and "long long" types are identical at runtime, > > > kstrtol() can be aliased to kstrtoll(). > > > > > > Unfortunately, one can't write > > > > > > __ __ __ __#if sizeof(long) == sizeof(long long) ... > > > > One can write #ifdef CONFIG_64BIT instead. > > And alignment will match, on any arch, now and in future? > I don't think so.
Don't worry about it.
z:/usr/src/linux-2.6.39> grep -r "#[ ]*if.*CONFIG_64BIT" . | wc -l 547
So much other stuff will break that kstrtofoo is a drop in the bucket.
| |