lkml.org 
[lkml]   [2011]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] ds2760_battery: Fix rated capacity of the hx4700 1800mAh battery
On Mon, Apr 25, 2011 at 01:45:40PM +0000, Paul Parsons wrote:
> Fix rated capacity of the HP iPAQ hx4700 3.7V 1800mAh (359113-001) battery. For this battery the value of the rated capacity EEPROM register at 0x32 is 7; thus rated_capacities[7] = 1800.
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>

Applied, thanks!

> ---
> --- clean-2.6.39-rc4/drivers/power/ds2760_battery.c 2011-03-15 01:20:32.000000000 +0000
> +++ linux-2.6.39-rc4/drivers/power/ds2760_battery.c 2011-04-25 13:06:29.344976841 +0100
> @@ -86,7 +86,11 @@ static int rated_capacities[] = {
> 920, /* NEC */
> 1440, /* Samsung */
> 1440, /* BYD */
> +#ifdef CONFIG_MACH_H4700

Note that this is OK as a temporary fix, but in general such fixups
should be done via platform data. So, it would be great if you could
prepare another patch on top of this one, which would do things in
a proper way.

> + 1800, /* HP iPAQ hx4700 3.7V 1800mAh (359113-001) */
> +#else
> 1440, /* Lishen */
> +#endif
> 1440, /* NEC */
> 2880, /* Samsung */
> 2880, /* BYD */

--
Anton Vorontsov
Email: cbouatmailru@gmail.com


\
 
 \ /
  Last update: 2011-05-20 17:55    [W:0.074 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site