lkml.org 
[lkml]   [2011]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices
Date
On Friday 20 May 2011 16:03:17 Shawn Guo wrote:
> On Fri, May 20, 2011 at 12:23:00PM +0200, Arnd Bergmann wrote:
> >
> > I know it's tempting to use macros for these, but I think it obscures
> > the code a lot, especially when you use them to concatenate identifier
> > names. Why not just do:
> >
> The pattern is being widely used in mxc/mxs platform device codes.
> If you are not extremely unhappy about this, I would leave it as it
> is to keep consistency.

I think it's a real pain to do it like this, and we need to start
at some point cleaning up the mess. Why not start now?

> > > +
> > > + return mxs_add_platform_device("mxs-gpio", data->id,
> > > + res, ARRAY_SIZE(res), NULL, 0);
> > > +}
> >
> > mxs_add_platform_device doesn't set the parent pointer correctly, I think you
> > should either fix that or open-code the platform device creation to do it
> > right.
> >
> I see the following in drivers/base/platform.c, function
> platform_device_add():
>
> if (!pdev->dev.parent)
> pdev->dev.parent = &platform_bus;
>
> So we are fine?

No, this would put all gpio devices below the top-level /sys/devices/platform
directory, where they certainly don't belong. Please find a proper
place and put them there.

Arnd


\
 
 \ /
  Last update: 2011-05-20 16:27    [from the cache]
©2003-2011 Jasper Spaans