Messages in this thread | | | Date | Mon, 2 May 2011 15:19:59 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH tip/core/rcu 11/86] rcu: Add boosting to TREE_PREEMPT_RCU tracing |
| |
On Mon, May 02, 2011 at 10:53:57AM -0700, Josh Triplett wrote: > On Mon, May 02, 2011 at 01:27:11AM -0700, Paul E. McKenney wrote: > > On Sun, May 01, 2011 at 08:52:25AM -0700, Josh Triplett wrote: > > > On Sun, May 01, 2011 at 06:20:51AM -0700, Paul E. McKenney wrote: > > > > From: Paul E. McKenney <paul.mckenney@linaro.org> > > > > > > > > Includes total number of tasks boosted, number boosted on behalf of each > > > > of normal and expedited grace periods, and statistics on attempts to > > > > initiate boosting that failed for various reasons. > > > > > > In this patch series, you have several cases where you improve the trace > > > output in one patch, and then update the documentation in a subsequent > > > patch. You might consider doing both in the same patch, so that at each > > > step the documentation matches the kernel. > > > > The reason I do the documentation second is that it allows me to copy > > the exact output from a test run, which has the nice side-effect of > > making sure that I really am getting the documentation correct. Or at > > least of reducing the probability of getting it wrong... ;-) > > I definitely agree that you should copy the output from a test run to > make the documentation accurate; I just mean that once you do so, you > should put both the code changes and corresponding documentation into a > single commit.
Fair enough, I did some squashing.
Thanx, Paul
| |