Messages in this thread Patch in this message | | | Date | Mon, 2 May 2011 09:15:46 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH tip/core/rcu 10/86] rcu: eliminate unused boosting statistics |
| |
On Mon, May 02, 2011 at 01:25:55AM -0700, Paul E. McKenney wrote: > On Sun, May 01, 2011 at 08:53:18AM -0700, Josh Triplett wrote: > > On Sun, May 01, 2011 at 06:20:50AM -0700, Paul E. McKenney wrote: > > > From: Paul E. McKenney <paul.mckenney@linaro.org> > > > > > > The n_rcu_torture_boost_allocerror and n_rcu_torture_boost_afferror > > > statistics are not actually incremented anymore, so eliminate them. > > > > > > Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org> > > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > > --- > > > kernel/rcutorture.c | 4 +--- > > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > > > diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c > > > index 4d256db..62ec8ee6 100644 > > > --- a/kernel/rcutorture.c > > > +++ b/kernel/rcutorture.c > > > @@ -1067,7 +1067,7 @@ rcu_torture_printk(char *page) > > > cnt += sprintf(&page[cnt], "%s%s ", torture_type, TORTURE_FLAG); > > > cnt += sprintf(&page[cnt], > > > "rtc: %p ver: %ld tfle: %d rta: %d rtaf: %d rtf: %d " > > > - "rtmbe: %d rtbke: %ld rtbre: %ld rtbae: %ld rtbafe: %ld " > > > + "rtmbe: %d rtbke: %ld rtbre: %ld " > > > "rtbf: %ld rtb: %ld nt: %ld", > > > rcu_torture_current, > > > rcu_torture_current_version, > > > @@ -1078,8 +1078,6 @@ rcu_torture_printk(char *page) > > > atomic_read(&n_rcu_torture_mberror), > > > n_rcu_torture_boost_ktrerror, > > > n_rcu_torture_boost_rterror, > > > - n_rcu_torture_boost_allocerror, > > > - n_rcu_torture_boost_afferror, > > > n_rcu_torture_boost_failure, > > > n_rcu_torture_boosts, > > > n_rcu_torture_timers); > > > > Shouldn't you eliminate the variables entirely, if they no longer track > > anything? > > I most certainly should!!! Good catch!!!
And here is the updated commit.
Thanx, Paul
------------------------------------------------------------------------
rcu: eliminate unused boosting statistics
The n_rcu_torture_boost_allocerror and n_rcu_torture_boost_afferror statistics are not actually incremented anymore, so eliminate them.
Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c index 4d256db..22b0e74 100644 --- a/kernel/rcutorture.c +++ b/kernel/rcutorture.c @@ -146,8 +146,6 @@ static atomic_t n_rcu_torture_mberror; static atomic_t n_rcu_torture_error; static long n_rcu_torture_boost_ktrerror; static long n_rcu_torture_boost_rterror; -static long n_rcu_torture_boost_allocerror; -static long n_rcu_torture_boost_afferror; static long n_rcu_torture_boost_failure; static long n_rcu_torture_boosts; static long n_rcu_torture_timers; @@ -1067,7 +1065,7 @@ rcu_torture_printk(char *page) cnt += sprintf(&page[cnt], "%s%s ", torture_type, TORTURE_FLAG); cnt += sprintf(&page[cnt], "rtc: %p ver: %ld tfle: %d rta: %d rtaf: %d rtf: %d " - "rtmbe: %d rtbke: %ld rtbre: %ld rtbae: %ld rtbafe: %ld " + "rtmbe: %d rtbke: %ld rtbre: %ld " "rtbf: %ld rtb: %ld nt: %ld", rcu_torture_current, rcu_torture_current_version, @@ -1078,16 +1076,12 @@ rcu_torture_printk(char *page) atomic_read(&n_rcu_torture_mberror), n_rcu_torture_boost_ktrerror, n_rcu_torture_boost_rterror, - n_rcu_torture_boost_allocerror, - n_rcu_torture_boost_afferror, n_rcu_torture_boost_failure, n_rcu_torture_boosts, n_rcu_torture_timers); if (atomic_read(&n_rcu_torture_mberror) != 0 || n_rcu_torture_boost_ktrerror != 0 || n_rcu_torture_boost_rterror != 0 || - n_rcu_torture_boost_allocerror != 0 || - n_rcu_torture_boost_afferror != 0 || n_rcu_torture_boost_failure != 0) cnt += sprintf(&page[cnt], " !!!"); cnt += sprintf(&page[cnt], "\n%s%s ", torture_type, TORTURE_FLAG); @@ -1486,8 +1480,6 @@ rcu_torture_init(void) atomic_set(&n_rcu_torture_error, 0); n_rcu_torture_boost_ktrerror = 0; n_rcu_torture_boost_rterror = 0; - n_rcu_torture_boost_allocerror = 0; - n_rcu_torture_boost_afferror = 0; n_rcu_torture_boost_failure = 0; n_rcu_torture_boosts = 0; for (i = 0; i < RCU_TORTURE_PIPE_LEN + 1; i++)
| |