Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] fs/fat: fix build warning | Date | Fri, 20 May 2011 08:23:01 +0900 |
| |
Linus Walleij <linus.walleij@stericsson.com> writes:
> From: Jonas Aberg <jonas.aberg@stericsson.com> > > This fixes a compile warning (unititialized variable) in > the fat filesystem code. > > Signed-off-by: Jonas Aberg <jonas.aberg@stericsson.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > fs/fat/dir.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/fat/dir.c b/fs/fat/dir.c > index ee42b9e..aace9be 100644 > --- a/fs/fat/dir.c > +++ b/fs/fat/dir.c > @@ -1229,7 +1229,7 @@ int fat_add_entries(struct inode *dir, void *slots, int nr_slots, > struct super_block *sb = dir->i_sb; > struct msdos_sb_info *sbi = MSDOS_SB(sb); > struct buffer_head *bh, *prev, *bhs[3]; /* 32*slots (672bytes) */ > - struct msdos_dir_entry *de; > + struct msdos_dir_entry *de = NULL; > int err, free_slots, i, nr_bhs; > loff_t pos, i_pos;
struct msdos_dir_entry *uninitialized_var(de);
IIRC, x86 gcc doesn't warn it. Does uninitialized_var(de) make your gcc version silent? If so, I'd like to change it like this.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |