Messages in this thread | | | From | H Hartley Sweeten <> | Date | Thu, 19 May 2011 16:18:56 -0500 | Subject | RE: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio |
| |
On Thursday, May 19, 2011 12:12 PM, Sascha Hauer wrote: > On Thu, May 19, 2011 at 09:56:32PM +0800, Shawn Guo wrote: >> On Thu, May 19, 2011 at 02:21:27PM +0200, Linus Walleij wrote: >>> On Thu, May 19, 2011 at 10:56 AM, Shawn Guo <shawn.guo@freescale.com> wrote: >>> >>>> I start working on moving mxs gpio (arch/arm/mach-mxs/gpio.c) into >>>> driver/gpio, and I see the possibility to go a different approach >>>> from U300 one posted here. >>> >>> I've tried to figure out what relation the mail has to the U300 driver >>> but cannot find any, more than that it's moving a driver... Please >>> start a new mail thread. >>> >> I will post mxs-gpio driver once I get it done. Then please review >> the code and see the difference between mxs-gpio and u300-gpio, >> though these hardwares have something in common. > > I'm pretty sure they have something in common and even more that *all* > gpio drivers have something in common. I wonder if it really makes sense > to move the gpio driver to drivers/gpio without creating a common > mmio_gpio_chip beforehand. This can't be very hard.
Jamie Iles (cc'ed) posted some patches that extended the basic_mmio_gpio driver so that it could be used as a library by other gpio drivers.
Jamie, could you re-post that series to the linux-arm-kernel list for review?
Thanks, Hartley
| |