Messages in this thread | | | Date | Thu, 19 May 2011 20:27:16 +0200 | From | Jens Axboe <> | Subject | Re: Perfromance drop on SCSI hard disk |
| |
On 2011-05-19 10:26, Alex,Shi wrote: > >> I will queue up the combined patch, it looks fine from here as well. >> > > When I have some time to study Jens and shaohua's patch today. I find a > simpler way to resolved the re-enter issue on starved_list. Following > Jens' idea, we can just put the starved_list device into kblockd if it > come from __scsi_queue_insert(). > It can resolve the re-enter issue and recover performance totally, and > need not a work_struct in every scsi_device. The logic/code also looks a > bit simpler. > What's your opinion of this?
Isn't this _identical_ to my original patch, with the added async run of the queue passed in (which is important, an oversight)?
-- Jens Axboe
| |