lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[14/21] x86, AMD: Fix ARAT feature setting again
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Borislav Petkov <borislav.petkov@amd.com>

    commit 14fb57dccb6e1defe9f89a66f548fcb24c374c1d upstream.

    Trying to enable the local APIC timer on early K8 revisions
    uncovers a number of other issues with it, in conjunction with
    the C1E enter path on AMD. Fixing those causes much more churn
    and troubles than the benefit of using that timer brings so
    don't enable it on K8 at all, falling back to the original
    functionality the kernel had wrt to that.

    Reported-and-bisected-by: Nick Bowler <nbowler@elliptictech.com>
    Cc: Boris Ostrovsky <Boris.Ostrovsky@amd.com>
    Cc: Andreas Herrmann <andreas.herrmann3@amd.com>
    Cc: Greg Kroah-Hartman <greg@kroah.com>
    Cc: Hans Rosenfeld <hans.rosenfeld@amd.com>
    Cc: Nick Bowler <nbowler@elliptictech.com>
    Cc: Joerg-Volker-Peetz <jvpeetz@web.de>
    Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
    Link: http://lkml.kernel.org/r/1305636919-31165-3-git-send-email-bp@amd64.org
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86/kernel/cpu/amd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/cpu/amd.c
    +++ b/arch/x86/kernel/cpu/amd.c
    @@ -568,7 +568,7 @@ static void __cpuinit init_amd(struct cp
    #endif

    /* As a rule processors have APIC timer running in deep C states */
    - if (c->x86 >= 0xf && !cpu_has_amd_erratum(amd_erratum_400))
    + if (c->x86 > 0xf && !cpu_has_amd_erratum(amd_erratum_400))
    set_cpu_cap(c, X86_FEATURE_ARAT);

    /*



    \
     
     \ /
      Last update: 2011-05-19 20:29    [W:4.219 / U:1.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site