lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[07/21] NET: slip, fix ldisc->open retval
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Matvejchikov Ilya <matvejchikov@gmail.com>

    commit 057bef938896e6266ae24ec4266d24792d27c29a upstream.

    TTY layer expects 0 if the ldisc->open operation succeeded.

    Signed-off-by : Matvejchikov Ilya <matvejchikov@gmail.com>
    Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
    Acked-by: Alan Cox <alan@linux.intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/slip.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/net/slip.c
    +++ b/drivers/net/slip.c
    @@ -850,7 +850,9 @@ static int slip_open(struct tty_struct *
    /* Done. We have linked the TTY line to a channel. */
    rtnl_unlock();
    tty->receive_room = 65536; /* We don't flow control */
    - return sl->dev->base_addr;
    +
    + /* TTY layer expects 0 on success */
    + return 0;

    err_free_bufs:
    sl_free_bufs(sl);



    \
     
     \ /
      Last update: 2011-05-19 20:29    [W:0.025 / U:29.420 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site