lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] perf: Split up buffer handling from core code

* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Thu, 2011-05-19 at 16:59 +0200, Frederic Weisbecker wrote:
> > I thought it would be nice to keep it inline for core use, as it's called
> > pretty often from the overflow path.
>
> That's what I meant.
>
> > A solution is to have a perf_output_copy_inline() in internal.h
> > and export it through perf_output_copy() in buffer.c
>
> If only "external inline" would work :-)
>
> I'd call it __perf_output_copy() though, less typing.

Just __output_copy() please - if someone is looking at kernel/events/*.c then
it's pretty clear that it's related to perf.

I.e. non-exposed symbols should lose their perf_ prefixes.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-19 19:23    [W:0.057 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site