lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateThu, 19 May 2011 16:14:59 +0200
FromFrederic Weisbecker <>
SubjectRe: [RFC PATCH] perf: Split up buffer handling from core code
On Thu, May 19, 2011 at 10:32:11AM +0200, Peter Zijlstra wrote:
> On Thu, 2011-05-19 at 09:31 +0200, Borislav Petkov wrote:
> >
> > Ok, maybe I'm missing something looking at this from the side but
> > perf_output_copy is used only internally by perf_event.c, i.e.
> > events/core.c, why not put it into the internal.h header?
>
> Not strictly true, but since the current inline is only valid for the
> existing perf_event.c its close enough :-)
>
> Anyway, I agree, stick it in internal.h :-)

Great. I kept it global because I read in a review from you
that you wanted it to stay a visible API. But if you're fine
with it internal, let's move it there.

Thanks.


\
 
 \ /
  Last update: 2011-05-19 16:17    [from the cache]
©2003-2010