lkml.org 
[lkml]   [2011]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] forcedeth: make module parameters readable in /sys/module
    Hi Stephen,

    On Wed, May 18, 2011 at 3:03 PM, Stephen Hemminger
    <shemminger@vyatta.com> wrote:
    > Although this makes more info for developer, it also means more
    > stuff in sysfs taking more memory and not providing any real value

    Right. I'll drop this patch for now.

    I do agree that this creates unnecessary pressure on some systems. But
    on other systems, it is useful to know how all the loaded modules were
    actually configured to track down something weird.

    Regarding /sys/modules/X/parameters, the only knobs I know of are
    CONFIG_SYSFS and the last argument to module_param(). If this is
    correct, then it seems tricky to accommodate for both use cases above
    without being crude (eg. disable sysfs, edit/sed the sources to change
    last argument of module_param() macro, ...). Please correct me if I am
    wrong. But if I am not, how about having a new knob allowing to
    precisely control the presence/absence of /sys/module (another
    CONFIG_*)? That way, the last argument to module_param() can be
    interpreted as the permission when /sys/module is supported, and would
    be ignored otherwise: module authors could gradually change their
    perm=S_IRUGO and family without caring much about memory footprint.
    And both use cases above could be supported without having to disable
    sysfs altogether or change the sources.

    I would be happy to work on this if it makes any sense.

    Regards,


    \
     
     \ /
      Last update: 2011-05-19 01:23    [W:0.022 / U:1.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site