lkml.org 
[lkml]   [2011]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] forcedeth: allow to silence tx_timeout debug messages
    From
    From: David Decotigny <decot@google.com>
    Date: Wed, 18 May 2011 14:43:58 -0700

    > On Wed, May 18, 2011 at 2:16 PM, David Miller <davem@davemloft.net> wrote:
    >> You can add a knob which when enabled gives the old verbosity
    >> back for diagnostic purposes.
    >
    > That was the intent of this patch: it adds a debug_tx_timeout module
    > parameter to act as the knob. I can rephrase the description of the
    > patch, it didn't make this so clear.
    > Or are you suggesting I should implement this with another kind of knob?

    I'm saying implement things differently.

    Reduce the verbosity of the TX timeout message but still print some
    amount of information, but provide a new knob that turns on the
    existing verbose messages.


    \
     
     \ /
      Last update: 2011-05-19 00:03    [W:0.021 / U:1.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site