Messages in this thread |  | | | From | Keith Packard <> | | Subject | Re: [PATCH] drm/i915/sdvo: Reorder i2c initialisation before ddc proxy | | Date | Tue, 17 May 2011 18:22:52 -0700 |
| |
On Tue, 17 May 2011 14:03:50 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote: > The ddc proxy depends upon the underlying i2c bus being selected. Under > certain configurations, the i2c-adapter functionality is queried during > initialisation and so may trigger an OOPS during boot. Hence, we need to > reorder the initialisation of the ddc proxy until after we hook up the i2c > adapter for the SDVO device.
I'd love more explanation here about how this code ever worked -- what are these 'certain configurations' of which you speak?
(on the surface, this patch seems sane, but I'd love to review with specific knowledge about what configurations would have worked and which would have triggered this bug).
-- keith.packard@intel.com [unhandled content-type:application/pgp-signature] |  |