Messages in this thread |  | | | Date | Tue, 17 May 2011 21:53:10 +0200 | | From | Sam Ravnborg <> | | Subject | Re: [PATCH] kconfig: Only generate config_is_xxx for bool and tristate options |
| |
On Tue, May 17, 2011 at 05:35:32PM +0200, Michal Marek wrote: > For strings and integers, the config_is_xxx macros are useless and > sometimes misleading: > > #define CONFIG_INITRAMFS_SOURCE "" > #define config_is_initramfs_source() 1
I'm late with this comment.... Could we introduce "config_is_foo" using a syntax that does not break grepability? Maybe a syntax like this?
#ifdef CONFIG_FOO
and
if (KCONFIG_FOO()) Grepping for the use of a symbol is a very typical thing, so we should try to keep this. And with the suggested syntax above I expect fixdep to catch up both usage types.
Sam
|  |