lkml.org 
[lkml]   [2011]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] mm: slub: Do not take expensive steps for SLUBs speculative high-order allocations
    On Tue, 17 May 2011, Christoph Lameter wrote:

    > > In this particular patch, the success rate for high order allocations
    > > would likely decrease in low memory conditions albeit the latency when
    > > calling the page allocator will be lower and the disruption to the
    > > system will be less (no copying or reclaim of pages). My expectation
    > > would be that it's cheaper for SLUB to fall back than compact memory
    > > or reclaim pages even if this means a slab page is smaller until more
    > > memory is free. However, if the "goodness" criteria is high order
    > > allocation success rate, the patch shouldn't be merged.
    >
    > The criteria is certainly overall system performance and not a high order
    > allocation rate.
    >

    SLUB definitely depends on these higher order allocations being successful
    for performance, dropping back to the min order is a last resort as
    opposed to failing the kmalloc(). If it's the last resort, then it makes
    sense that we'd want to try both compaction and reclaim while we're
    already in the page allocator as we go down the slub slowpath. Why not
    try just a little harder (compaction and/or reclaim) to alloc the cache's
    preferred order?


    \
     
     \ /
      Last update: 2011-05-17 21:37    [W:3.041 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site