Messages in this thread | | | Date | Tue, 17 May 2011 11:32:59 -0700 | From | Greg KH <> | Subject | Re: [PATCH v2 3/3] PM / DEVFREQ: add sysfs interface (including user tickling) |
| |
On Tue, May 17, 2011 at 02:04:52PM +0900, MyungJoo Ham wrote: > On Thu, May 12, 2011 at 7:55 AM, Greg KH <gregkh@suse.de> wrote: > > On Wed, May 11, 2011 at 04:58:43PM +0900, MyungJoo Ham wrote: > >> 1. System-wide sysfs interface > >> - tickle_all R: number of tickle_all execution > >> W: tickle all devfreq devices > >> - min_interval R: devfreq monitoring base interval in ms > >> - monitoring R: shows whether devfreq monitoring is active or > >> not. > >> > >> 2. Device specific sysfs interface > >> - tickle R: number of tickle execution for the device > >> W: tickle the device > > > > Any sysfs file change/addition/removal needs to have a > > Documentation/ABI/ entry as well. Please add that to this patch instead > > of burying it in the changelog entry, where no one will be able to find > > it in the future. > > > > thanks, > > > > greg k-h > > > > Sure, I'll add Documentation/ABI/testing/* entries. > > However, would it be appropriate for "1. System-wide sysfs interface" > to be in "sysfs-class-power" and for "2. Device specific sysfs > interface" to be in "sysfs-devices-devfreq"? > > System-wide sysfs interface is in /sys/class/power/devfreq/* and > Device specific sysfs interface is in /sys/...DEVICE.../devfreq/* .
That makes sense.
thanks,
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |