| Date | Tue, 17 May 2011 12:22:24 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 01/10] signal: remove three noop tracehooks |
| |
On Mon, May 16, 2011 at 08:17:20PM +0200, Tejun Heo wrote: > Remove the following three noop tracehooks in signals.c. > > * tracehook_force_sigpending() > * tracehook_get_signal() > * tracehook_finish_jctl() > > The code area is about to be updated and these hooks don't do anything > other than obfuscating the logic.
Btw, I think we should kill that stupid <linux/tracehook.h> layer entirely. It consists of a few relatively useful function which should just be renamed to ptrace_* and moved to ptrace.c, and a lot of entirely pointless wrappers which generally have only a single user, and often tons of arguments that aren't actually used.
|