lkml.org 
[lkml]   [2011]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/urgent] x86, AMD: Fix ARAT feature setting again
    Commit-ID:  14fb57dccb6e1defe9f89a66f548fcb24c374c1d
    Gitweb: http://git.kernel.org/tip/14fb57dccb6e1defe9f89a66f548fcb24c374c1d
    Author: Borislav Petkov <borislav.petkov@amd.com>
    AuthorDate: Tue, 17 May 2011 14:55:19 +0200
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Tue, 17 May 2011 15:28:34 +0200

    x86, AMD: Fix ARAT feature setting again

    Trying to enable the local APIC timer on early K8 revisions
    uncovers a number of other issues with it, in conjunction with
    the C1E enter path on AMD. Fixing those causes much more churn
    and troubles than the benefit of using that timer brings so
    don't enable it on K8 at all, falling back to the original
    functionality the kernel had wrt to that.

    Reported-and-bisected-by: Nick Bowler <nbowler@elliptictech.com>
    Cc: Boris Ostrovsky <Boris.Ostrovsky@amd.com>
    Cc: Andreas Herrmann <andreas.herrmann3@amd.com>
    Cc: Greg Kroah-Hartman <greg@kroah.com>
    Cc: Hans Rosenfeld <hans.rosenfeld@amd.com>
    Cc: Nick Bowler <nbowler@elliptictech.com>
    Cc: Joerg-Volker-Peetz <jvpeetz@web.de>
    Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
    Link: http://lkml.kernel.org/r/1305636919-31165-3-git-send-email-bp@amd64.org
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    arch/x86/kernel/cpu/amd.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
    index 3532d3b..6f9d1f6 100644
    --- a/arch/x86/kernel/cpu/amd.c
    +++ b/arch/x86/kernel/cpu/amd.c
    @@ -613,7 +613,7 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
    #endif

    /* As a rule processors have APIC timer running in deep C states */
    - if (c->x86 >= 0xf && !cpu_has_amd_erratum(amd_erratum_400))
    + if (c->x86 > 0xf && !cpu_has_amd_erratum(amd_erratum_400))
    set_cpu_cap(c, X86_FEATURE_ARAT);

    /*

    \
     
     \ /
      Last update: 2011-05-17 15:49    [W:0.023 / U:235.996 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site