Messages in this thread | | | Subject | Re: [PATCH 3/3] checkpatch.pl: Add check for task comm references | Date | Mon, 16 May 2011 23:29:02 +0200 | From | "Michal Nazarewicz" <> |
| |
On Mon, 16 May 2011 23:19:17 +0200, John Stultz wrote: > Now that accessing current->comm needs to be protected, > @@ -2868,6 +2868,10 @@ sub process { > WARN("usage of NR_CPUS is often wrong - consider using > cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . > $herecurr); > } > +# check for current->comm usage > + if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) {
Not a checkpatch.pl expert but as far as I'm concerned, that looks reasonable.
I was sort of worried that t->comm could produce quite a few false positives but all its appearances in the kernel (seem to) refer to task.
> + WARN("comm access needs to be protected. Use get_task_comm, or > printk's \%ptc formatting.\n" . $herecurr); > + } > # check for %L{u,d,i} in strings > my $string; > while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +-----<email/xmpp: mnazarewicz@google.com>-----ooO--(_)--Ooo--
| |