Messages in this thread |  | | | Date | Fri, 13 May 2011 10:36:52 +0200 | | From | Jean-Christophe PLAGNIOL-VILLARD <> | | Subject | Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro |
| |
On 10:30 Fri 13 May , Ingo Molnar wrote: > > * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote: > > > -#ifdef CONFIG_PCI_BIOS > > - if (!rt->signature) { > > + if (config_is_pci_bios() && !rt->signature) { > > Makes sense - but please name it in a more obvious way, such as: > > pci_bios_enabled() the idea to generate the macro via Kconfig
so I propose config_is_pci_bios() and if it's a module config_is_pci_bios_module()
if you have a better convention naming I'm fine to change it
maybe
config_pci_bios_enabled() / config_pci_bios_module_enabled
or
pci_bios_enabled() / pci_bios_module_enabled()
Best Regards, J.
|  |