lkml.org 
[lkml]   [2011]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] signal: trivial, fix the "timespec declared inside parameter list" warning
    On Fri, May 13, 2011 at 12:44, Oleg Nesterov wrote:
    > --- sigprocmask/include/linux/signal.h~15_stw_warning   2011-05-12 20:44:43.000000000 +0200
    > +++ sigprocmask/include/linux/signal.h  2011-05-13 18:10:40.000000000 +0200
    > @@ -242,6 +242,7 @@ extern int __group_send_sig_info(int, st
    >  extern long do_rt_tgsigqueueinfo(pid_t tgid, pid_t pid, int sig,
    >                                 siginfo_t *info);
    >  extern long do_sigpending(void __user *, unsigned long);
    > +struct timespec;
    >  extern int do_sigtimedwait(const sigset_t *, siginfo_t *,
    >                                const struct timespec *);
    >  extern int sigprocmask(int, sigset_t *, sigset_t *);

    seems like you'd want to stick this higher up in the file (like after
    the includes or at the top of the prototype block) so that in the
    future, you dont have to move it if someone adds a new func before it.
    -mike
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-05-13 20:11    [W:4.025 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site