lkml.org 
[lkml]   [2011]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] mm: vmscan: Correct use of pgdat_balanced in sleeping_prematurely
    Date
    Johannes Weiner poined out that the logic in commit [1741c877: mm:
    kswapd: keep kswapd awake for high-order allocations until a percentage
    of the node is balanced] is backwards. Instead of allowing kswapd to go
    to sleep when balancing for high order allocations, it keeps it kswapd
    running uselessly.

    From-but-was-not-signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
    Will-sign-off-after-Johannes: Mel Gorman <mgorman@suse.de>
    ---
    mm/vmscan.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/mm/vmscan.c b/mm/vmscan.c
    index f6b435c..af24d1e 100644
    --- a/mm/vmscan.c
    +++ b/mm/vmscan.c
    @@ -2286,7 +2286,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining,
    * must be balanced
    */
    if (order)
    - return pgdat_balanced(pgdat, balanced, classzone_idx);
    + return !pgdat_balanced(pgdat, balanced, classzone_idx);
    else
    return !all_zones_ok;
    }
    --
    1.7.3.4


    \
     
     \ /
      Last update: 2011-05-13 16:07    [W:0.020 / U:33.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site