Messages in this thread | | | Subject | Re: [PATCH] dmaengine: at_hdmac: pause: no need to wait for FIFO empty | From | "Koul, Vinod" <> | Date | Thu, 12 May 2011 13:58:56 +0530 |
| |
On Mon, 2011-05-09 at 18:11 +0200, Nicolas Ferre wrote: > The addition of the pause feature to atc_control an active wait was introduced > to check the FIFO empty event. This event was not always happening and > a timout contition was needed. > But, in some cases, this event depend on the peripheral connected to the > channel that is paused: FIFO becomes empty if the peripheral consumes data. > The timeout is pretty difficult to evaluate. Moreover, this check is not > needed. > In conclusion, it seems sensible to entirely remove the checking of > "FIFO empty" status when pausing. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > --- > Vinod, > > This additional patch goes on top of your current "next" branch. It is a > removing of some code added to the pause/resume patch sent earlier and can be > folded into this one if you want to. > Applied with edit in commit msg, Thanks
-- ~Vinod
| |