| Date | Fri, 13 May 2011 08:44:20 +1000 | From | Dave Chinner <> | Subject | Re: [PATCH 03/17] writeback: introduce writeback_control.inodes_cleaned |
| |
On Thu, May 12, 2011 at 09:57:09PM +0800, Wu Fengguang wrote: > The flusher works on dirty inodes in batches, and may quit prematurely > if the batch of inodes happen to be metadata-only dirtied: in this case > wbc->nr_to_write won't be decreased at all, which stands for "no pages > written" but also mis-interpreted as "no progress". > > So introduce writeback_control.inodes_cleaned to count the inodes get > cleaned. A non-zero value means there are some progress on writeback, > in which case more writeback can be tried.
Why introduce a new field for this? Just decrement nr_to_write for every write_inode() call made in writeback_single_inode()....
Cheers,
Dave. -- Dave Chinner david@fromorbit.com
|