[lkml]   [2011]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/4] mm: Remove dependency on CONFIG_FLATMEM from online_page()
On Thu, 12 May 2011, Daniel Kiper wrote:

> > > Memory hotplug code strictly depends on CONFIG_SPARSEMEM.
> > > It means that code depending on CONFIG_FLATMEM in online_page()
> > > is never compiled. Remove it because it is not needed anymore.
> > >
> > > Signed-off-by: Daniel Kiper <>
> >
> > The code you're patching depends on CONFIG_MEMORY_HOTPLUG_SPARSE, so this
> > is valid. The changelog should be updated to reflect that, however.
> >
> > Acked-by: David Rientjes <>
> No problem, however, this bundle of patches was added to the -mm tree.
> In this situation should I repost whole bundle with relevant changes
> or post only those two patches requested by you ??? For which tree
> should I prepare new version of patches ???

No, I would just reply to the email notification you received when the
patch went into -mm saying that the changelog should be adjusted to read
something like

online_pages() is only compiled for CONFIG_MEMORY_HOTPLUG_SPARSE,
so there is no need to support CONFIG_FLATMEM code within it.

This patch removes code that is never used.

 \ /
  Last update: 2011-05-12 21:29    [W:0.079 / U:10.436 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site